add test for test-logging-tx-observer

[tunedev]

Checklist

• A link to the issue/user story that the pull request relates to
• How to recreate the problem without the fix
• Design of the fix
• How to prove that the fix works
• Automated tests that prove the fix keeps on working
• Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Partially addresses #1606

Steps to Reproduce

Existing issues

• Stack Overflow issues
• GitHub Issues
• Discord history

Design of the fix

Validation of the fix

After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed

• caliper-core/lib/worker/tx-observers/logging-tx-observer.js: 100

Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before

• caliper-core/lib/worker/tx-observers/logging-tx-observer.js: 0

Automated Tests

What documentation has been provided for this pull request

[davidkel]

Sorry, needs a few changes here. It also breaks the build (see the build details in the PR and github actions). Please run the unit and integration tests before submitting the PR to avoid this

[davidkel]

One last change

[davidkel]

You need to change this test, logStubs.info will always exist because you create it in the test. So the test doesn't actually prove anything

[tunedev]

true, would remove it now

…

On Thu, 10 Oct 2024 at 08:38, Dave Kelsey ***@***.***> wrote: ***@***.**** requested changes on this pull request. One last change ------------------------------ In packages/caliper-core/test/worker/tx-observers/logging-tx-observer.js <#1630 (comment)>: > + logStub = CaliperUtils.getLogger().info; + observer = createLoggingTxObserver({ messageLevel: 'info' }, null, 0); + }); + + afterEach(() => { + sinon.restore(); + logStub.resetHistory(); + }); + + after(() => { + mockery.deregisterAll(); + mockery.disable(); + }); + + describe('On initialization', () => { + it('should set up the logger with default settings if no options are provided', () => { You need to change this test, logStubs.info will always exist because you create it in the test. So the test doesn't actually prove anything — Reply to this email directly, view it on GitHub <#1630 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH6TKS2NBGHBEFK76BB3YXDZ2YVHXAVCNFSM6AAAAABOAQ4Z5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJVGEZTKOBVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[davidkel]

LGTM