Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in fix-load documentation #1576

Merged
merged 8 commits into from
May 17, 2024

Conversation

duckling69
Copy link
Contributor

Fix 1471

Checklist

  • A link to the issue/user story that the pull request relates to

Existing issues

#1471

@duckling69
Copy link
Contributor Author

can you review this? // @aklenik @davidkel

Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was only about the fix-load rate controller. Changing the linear-rate (and possibly other) docs is incorrect, since the code indeed uses the startingTps naming.

@aklenik aklenik added PR/change requested The PR is blocked until the requested changes are applied documentation Related to the documentation labels May 16, 2024
Signed-off-by: Vivek Jha <[email protected]>
@duckling69 duckling69 requested a review from aklenik May 16, 2024 21:21
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed changing the description of the options, it still says startingTps

### Options and use
The fixed-load controller can be specified by setting the rate controller `type` to the `fixed-load` string.
Controller options include:
- `startingTps`: the initial rate at which transactions are cumulatively sent to the SUT by all workers
- `transactionLoad`: the number of transactions being processed by the SUT that is to be maintained
The fixed load controller, aiming to maintain a SUT transaction load of 5, with a starting TPS of 100, is specified through the following controller option:
```json
{
  "type": "fixed-load",
  "opts": {
    "transactionLoad": 5,
    "startTps": 100
  }
}

Signed-off-by: Vivek Jha <[email protected]>
@duckling69
Copy link
Contributor Author

Thanks for reviewing I think I've done all reviewed changes // @davidkel @aklenik

@duckling69 duckling69 requested a review from davidkel May 16, 2024 21:48
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for the contribution

@davidkel davidkel removed the request for review from aklenik May 17, 2024 07:59
@davidkel davidkel dismissed aklenik’s stale review May 17, 2024 10:07

I've reviewed the new updates and all looks good

@davidkel davidkel merged commit 4c36ad0 into hyperledger-caliper:gh-pages May 17, 2024
2 checks passed
@davidkel davidkel linked an issue May 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to the documentation PR/change requested The PR is blocked until the requested changes are applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixed-load documentation states startingTps, code states startTps
3 participants