-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo fix in fix-load documentation #1576
Conversation
Signed-off-by: Vivek jha <[email protected]>
Signed-off-by: Vivek jha <[email protected]>
Signed-off-by: Vivek Jha <[email protected]>
Signed-off-by: Vivek Jha <[email protected]>
Signed-off-by: Vivek Jha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was only about the fix-load rate controller. Changing the linear-rate (and possibly other) docs is incorrect, since the code indeed uses the startingTps
naming.
Signed-off-by: Vivek Jha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed changing the description of the options, it still says startingTps
### Options and use
The fixed-load controller can be specified by setting the rate controller `type` to the `fixed-load` string.
Controller options include:
- `startingTps`: the initial rate at which transactions are cumulatively sent to the SUT by all workers
- `transactionLoad`: the number of transactions being processed by the SUT that is to be maintained
The fixed load controller, aiming to maintain a SUT transaction load of 5, with a starting TPS of 100, is specified through the following controller option:
```json
{
"type": "fixed-load",
"opts": {
"transactionLoad": 5,
"startTps": 100
}
}
Signed-off-by: Vivek Jha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, many thanks for the contribution
I've reviewed the new updates and all looks good
Fix 1471
Checklist
Existing issues
#1471