Add fallback for Missing Google Search API #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2015 22:47
It can now add the query string to the fallback URL. Also updated the documentation
|
👍 |
| @@ -99,37 +100,16 @@ imageMe = (msg, query, animated, faces, cb) -> | |||
| .error "(see #{error.extendedHelp})" if error.extendedHelp | |||
| ) error for error in response.error.errors if response.error?.errors | |||
| else | |||
| msg.send "Google Image Search API is not longer available. " + | |||
| "Please setup up Custom Search Engine API." | |||
There was a problem hiding this comment.
Linking to documentation on how to set this up would definitely help users.
|
It looks like |
|
This is really just a temporary notice until we can get CSE plus some fallback like Bing images integrated, |
HaroldPutman
pushed a commit
that referenced
this pull request
Dec 7, 2015
Add fallback for Missing Google Search API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #29 by showing a message and a fallback image.
Google Image Search API is not longer available. Please setup up Custom Search Engine API.
You can provide a different fallback URL by defining the environment variable HUBOT_GOOGLE_IMAGES_FALLBACK. If you put
{q}in the URL it will be replaced by the URL escaped query string. (for examplehttp://placehold.it/480x150?text={q})