Add gRPC status codes #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
reviewed
Oct 25, 2024
codegen/testing/src/test/scala/hello/world/TestServiceSuite.scala
Outdated
Show resolved
Hide resolved
Comment on lines
+8
to
+9
| def asStatusRuntimeException(message: Option[String] = None): StatusRuntimeException = | ||
| StatusRuntimeException(this, message) |
There was a problem hiding this comment.
Is it legit for the Ok status to be considered as StatusRuntimeException?
There was a problem hiding this comment.
Yeah, it feels weird. We could further divide codes into success and errors.
There was a problem hiding this comment.
Just passing by, but I think we should take gRPC richer error model into consideration for error handling design because there are more and more gRPC implementations that can send extra error details in trailers header（e.g. golang, Java or Rust implementation).
See
- https://grpc.io/docs/guides/error/#richer-error-model
- https://github.com/googleapis/googleapis/blob/e67f6bea8425bbc3a6352ffea8ce2bc6dab45454/google/rpc/status.proto#L35
for more details.
There was a problem hiding this comment.
@danicheg How about making the status Ok package private, since user code should never need it anyways?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at solving #135.