(#314) Fix NPE on clearParameters (#315)

housepower · Mar 1, 2021 · 79083a8 · 79083a8
1 parent e87c8ec
commit 79083a8
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/...ve-jdbc/src/main/java/com/github/housepower/jdbc/statement/AbstractPreparedStatement.java b/...ve-jdbc/src/main/java/com/github/housepower/jdbc/statement/AbstractPreparedStatement.java
@@ -165,7 +165,9 @@ public ResultSetMetaData getMetaData() throws SQLException {
 
     @Override
     public void clearParameters() throws SQLException {
-        Arrays.fill(parameters, null);
+        if (parameters != null) {
+            Arrays.fill(parameters, null);
+        }
     }
 
     protected String assembleQueryPartsAndParameters() throws SQLException {

diff --git a/clickhouse-native-jdbc/src/test/java/com/github/housepower/jdbc/PreparedStatementITest.java b/clickhouse-native-jdbc/src/test/java/com/github/housepower/jdbc/PreparedStatementITest.java
@@ -14,6 +14,7 @@
 
 package com.github.housepower.jdbc;
 
+import com.github.housepower.jdbc.annotation.Issue;
 import com.github.housepower.jdbc.misc.DateTimeUtil;
 import org.junit.jupiter.api.Test;
 
@@ -234,4 +235,22 @@ public void successfullyInsertData() throws Exception {
         });
     }
 
+    @Test
+    @Issue(channel = "GitHub", value = "314", link = "https://github.com/housepower/ClickHouse-Native-JDBC/issues/314")
+    public void ghIssue314() throws Exception {
+        withNewConnection(connection -> {
+            Statement statement = connection.createStatement();
+
+            statement.execute("DROP TABLE IF EXISTS test");
+            statement.execute("CREATE TABLE test(id UInt8)ENGINE = Log");
+
+            PreparedStatement preparedStatement = connection.prepareStatement("INSERT INTO test VALUES(?)");
+            preparedStatement.clearParameters();
+            preparedStatement.setByte(1, (byte) 1);
+            preparedStatement.clearParameters();
+            preparedStatement.setByte(1, (byte) 1);
+            assertEquals(1, preparedStatement.executeUpdate());
+        });
+    }
+
 }