Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support .md #188

Merged
merged 1 commit into from
Jun 8, 2024
Merged

feat: support .md #188

merged 1 commit into from
Jun 8, 2024

Conversation

goisaki
Copy link
Contributor

@goisaki goisaki commented Jun 8, 2024

This PR adds .md as a route file extension and also supports omission of the extension.
This should be provided as a config so that other extensions can do this, but vite does not support it.

closes: #187

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jun 8, 2024

Thanks @goisaki !

@yusukebe yusukebe merged commit f9fbe4f into honojs:main Jun 8, 2024
2 checks passed
@goisaki
Copy link
Contributor Author

goisaki commented Jun 8, 2024

Wow! It was fast!

@yusukebe
Copy link
Member

yusukebe commented Jun 8, 2024

You too!

@goisaki goisaki deleted the feat/support-md branch June 8, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .md / custom extension omission
2 participants