Change FS from SPIFFS to LittleFS #684
Conversation
|
I use to upload my config.json for every device to SPIFFS. I don't use the config mode at all and I even use the compile flag to remove the code for the config mode. How do I upload the config.json to LittleFS? |
|
I also replaced all occurrences of Spiffs with LittleFS, but I see two pending problems:
I'm pretty sure we shouldn't mix the two and I'm also pretty sure that we should put everything into defines at least for some time, so that people can have spiffs as default. After a while we could make LittleFS the default. Which is why I haven't pursued the issue further (yet) |
|
closes #682 |
|
Hi! i got work it with this... me-no-dev/ESPAsyncWebServer#792 (comment) |
|
Is LittleFS availlable on ESP32? |
|
Is there a migration strategy for moving from SPIFFS to LittleFS? If SPIFFS is used in actual products, there is data stored in those products that can't just be thrown away if the software is upgraded. |
|
That is exactly the reason why I haven't merged anything yet. I remember coming across a project that worked on in-place migration of the data, but can't find it now. |
…y try MQTT connect if WiFi is connected for ESP8266 from matzrh/homie-esp8266
|
Hi, Nevertheless, I feel the pain loosing data. So I'd suggest a process (and maybe tools/simple sketches) to download the data, update the system and upload the data. Either manually done, or by leveraging the OTA feature. Well documented, but not implemented into this project. You also might want to read this thread, discussing this topic, options and efforts. Also, for a limited time and depending on the effort, both spiffs and littlefs could be supported by using compiler flags, resulting in running either spiffs or littlefs (but not both at the same time). So people have some time to migrate their systems. Thoughts? |
|
Supporting both filesystems through compiler flags was an earlier suggestion, too. This absolutely makes sense. I personally am still missing a tool to upload config.json to LittleFS filesystem, so I can test it. |
|
Afaik, ArduinoIDE supports uploading files to littlefs. But I'm not sure if it's already built in or a plugin is required. May I ask what exactly you're missing? Don't you use ArduinoIDE or PlatformIO? |
|
I am using PlatformIO and did not have a look yet into PlatformIO and LittleFS. Good to hear, that it is supported. |
| @@ -85,11 +85,11 @@ bool Config::load() { | |||
| const char* reqWifiDns2 = reqWifi["dns2"] | ""; | |||
|
|
|||
| uint16_t reqMqttPort = reqMqtt["port"] | DEFAULT_MQTT_PORT; | |||
| bool reqMqttSsl = reqMqtt["ssl"] | false; | |||
| // bool reqMqttSsl = reqMqtt["ssl"] | false; | |||
There was a problem hiding this comment.
This would break MQTT over SSL for me.
As this PR contains a mixture of multiple things:
- ota_updater changes
- LittleFS support
- broken SSL support
- changes on WiFi connect behaviour
we should split this up into multiple smaller PRs covering each a single topic. I will take care about a compiler flags driven switch between SPIFFS and LittleFS.
There was a problem hiding this comment.
Thank you, for the review. Maybe the ota_updater changes are caused by merging my changes back into his fork?
I also started working on the LittleFS change but stopped when it came to the async web server, since it doesn't support LittleFS. IMO LittleFS can right now only be supported with HOMIE_CONFIG=0. When the web server is used, we should default to SPIFFS.
There was a problem hiding this comment.
I did not have a look at the commits and commit history but I think, we should try to keep Git history a little bit clean. For me code changes are already hard to follow.
Maybe I can make compile fail if LittleFS is selected without disabling the web server.
There was a problem hiding this comment.
It's better with a clean start. If you give it a go using this PR as inspiration, we can close this one in a few days.
Failing the compilation should be easy with a set of nested #if(n)defs
Just replace FS ... work for me...