Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for new integration igloohome #35784

Open
wants to merge 14 commits into
base: next
Choose a base branch
from

Conversation

keithle888
Copy link

@keithle888 keithle888 commented Nov 16, 2024

Proposed change

Added markdown documentation for new core integration 'igloohome'

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Introduced comprehensive documentation for the igloohome integration with Home Assistant, detailing functionality and setup.
    • Provided a step-by-step guide for connecting igloohome devices and updating battery levels.
  • Documentation

    • Added prerequisites and instructions for obtaining API credentials required for the integration, including sign-in and inputting Client ID and Client Secret.
    • Included guidance for verifying successful integration and recognizing battery entities.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 16, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 0c7dc1d
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/673b8be7cd214f00080d122f
😎 Deploy Preview https://deploy-preview-35784--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@klaasnicolaas klaasnicolaas changed the base branch from current to next November 16, 2024 10:18
@home-assistant home-assistant bot added next This PR goes into the next branch and removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 16, 2024
@keithle888
Copy link
Author

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Does anyone know if this is something I can ignore? This PR looks to be correctly targetting the next branch of the main-repo.

@keithle888 keithle888 marked this pull request as ready for review November 16, 2024 16:20
Copy link
Contributor

coderabbitai bot commented Nov 16, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes introduce a new documentation file for the igloohome integration with Home Assistant. This documentation details the integration's functionality, setup process, and prerequisites, including the need for an iglooaccess account. It provides a step-by-step guide for users to configure the integration using API credentials and categorizes the integration under sensors, with defined attributes.

Changes

File Change Summary
source/_integrations/igloohome.markdown Added new documentation for igloohome integration, detailing functionality, setup process, and prerequisites.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Home Assistant
    participant igloodeveloper API

    User->>Home Assistant: Sign in and input API credentials
    Home Assistant->>igloodeveloper API: Request device battery levels
    igloodeveloper API-->>Home Assistant: Return battery level updates
    Home Assistant-->>User: Display device status
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (3)
source/_integrations/igloohome.markdown (3)

20-22: Consider adding more account details

While the prerequisite is clear, it would be helpful to mention any specific account requirements (e.g., free vs paid account) or regional availability limitations if any exist.


26-33: Fix formatting and typos in setup instructions

There are several issues in the setup instructions:

  1. Typo: "crendentials" should be "credentials"
  2. Lists should be surrounded by blank lines
  3. Remove trailing spaces after "Home Assistant"
 Once the account has been created:
+
 - [Sign in](https://access.igloocompany.co/login).
 - Jump to [API access](https://access.igloocompany.co/api-access).
-  - Create a set of crendentials with the name `Home Assistant`. 
+  - Create a set of credentials with the name `Home Assistant`.
 - Copy out the `Client ID` & `Client Secret`.
 - Add this integration to your Home Assistance instance.
 - Copy the `Client ID` & `Client Secret` to the respective text fields when prompted by the integration.
 - The integration will retrieve the devices under your account and update their last known battery level regularly.
🧰 Tools
🪛 Markdownlint

29-29: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


27-27: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


33-33: Consider adding a troubleshooting section

To improve user experience, consider adding a troubleshooting section that covers:

  • Common setup issues
  • API rate limits or connectivity problems
  • Steps to take if device updates fail
  • How to verify successful integration

Would you like me to provide a template for the troubleshooting section?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c45a4da and d384220.

📒 Files selected for processing (1)
  • source/_integrations/igloohome.markdown (1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown

29-29: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


27-27: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)

18-18: LGTM!

Good use of the {% term integration %} template syntax and proper linking to the API documentation.


7-7: Review the release version

The ha_release value of "0.0.1" seems incorrect. For new integrations, this should typically match the upcoming Home Assistant release version.

source/_integrations/igloohome.markdown Outdated Show resolved Hide resolved
- Corrected spelling mistake.
- Corrected spelling mistake.
- Added blank line between list
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Outside diff range and nitpick comments (1)
source/_integrations/igloohome.markdown (1)

41-42: Remove extra blank lines

Remove the extra blank lines at the end of the file.

 
-
-
🧰 Tools
🪛 Markdownlint

41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d384220 and b65559b.

📒 Files selected for processing (1)
  • source/_integrations/igloohome.markdown (1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown

40-40: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


38-38: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)

4-5: Add lock platform to ha_platforms

The integration appears to support locks based on the API documentation, but only the sensor platform is listed.

 ha_category:
   - Sensor
+  - Lock
 ...
 ha_platforms:
   - sensor
+  - lock

Also applies to: 12-13


21-21: Clarify account requirements

Please specify if the iglooaccess account is free or requires a subscription/payment.

source/_integrations/igloohome.markdown Outdated Show resolved Hide resolved
source/_integrations/igloohome.markdown Show resolved Hide resolved
source/_integrations/igloohome.markdown Show resolved Hide resolved
source/_integrations/igloohome.markdown Outdated Show resolved Hide resolved
source/_integrations/igloohome.markdown Show resolved Hide resolved
- Change ha_release
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
source/_integrations/igloohome.markdown (2)

32-33: Consider adding expected outcome after setup

The setup instructions are clear, but consider adding a note about what users should expect to see in their Home Assistant dashboard after successful setup (e.g., where to find the battery sensors).

 - Copy the `Client ID` & `Client Secret` to the respective text fields when prompted by the integration.
 - The integration will retrieve the devices under your account and update their last known battery level regularly.
+- After successful setup, battery sensors for your devices will appear in your Home Assistant dashboard under the "Sensor" domain.

38-42: Fix markdown formatting issues

There are several formatting issues in this section that should be addressed:

+
 - Battery entities:
   - Devices that have a battery level should be automatically recognized, and entities created. If devices are added post-integration, kindly reload the set of `Client Credentials`.
-  
-

-
+
🧰 Tools
🪛 Markdownlint

40-40: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


38-38: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b65559b and 1246ce7.

📒 Files selected for processing (1)
  • source/_integrations/igloohome.markdown (1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown

40-40: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


38-38: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)

17-17: LGTM!

The introduction clearly describes the integration's current functionality.


19-21: LGTM!

Prerequisites are clearly stated with the necessary registration link.

source/_integrations/igloohome.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
source/_integrations/igloohome.markdown (3)

19-21: Consider expanding prerequisites section

To help users prepare better, consider adding more details such as:

  • Whether a free account is sufficient or if a paid subscription is required
  • Any regional availability restrictions
  • Minimum firmware requirements for compatible devices

35-42: Fix markdown formatting issues

There are some formatting issues that need to be addressed:

  • Remove trailing space on line 40
  • Remove extra blank lines at the end of the file

Apply this diff:

 Once the correct `Client ID` & `Client Secret` has been provided:
 - Battery entities:
   - Devices that have a battery level should be automatically recognized, and entities created. If devices are added post-integration, kindly reload the set of `Client Credentials`.
-  
-

-
+
🧰 Tools
🪛 Markdownlint

40-40: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


38-38: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


42-42: Consider adding a troubleshooting section

To enhance user experience, consider adding a troubleshooting section that covers:

  • Common setup issues and their solutions
  • API rate limits or timeout issues
  • Steps to take when device updates fail
  • How to resolve authentication problems
🧰 Tools
🪛 Markdownlint

42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1246ce7 and 0c7dc1d.

📒 Files selected for processing (1)
  • source/_integrations/igloohome.markdown (1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown

40-40: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines

(MD012, no-multiple-blanks)


38-38: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

🔇 Additional comments (1)
source/_integrations/igloohome.markdown (1)

23-33: LGTM! Clear and well-structured setup instructions

The setup instructions are clear, concise, and provide a good step-by-step guide for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant