-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADS configuration flow docs #35724
base: next
Are you sure you want to change the base?
Add ADS configuration flow docs #35724
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes made in the pull request primarily enhance the documentation for the ADS integration in Home Assistant. A new configuration flow feature is introduced by adding Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant ADS_Integration
User->>UI: Access ADS configuration
UI->>ADS_Integration: Request configuration options
ADS_Integration-->>UI: Provide configuration flow options
UI->>User: Display configuration options
User->>UI: Select configuration method
UI->>ADS_Integration: Apply selected configuration
ADS_Integration-->>UI: Confirm configuration applied
UI->>User: Show success message
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
source/_integrations/ads.markdown (1)
47-49
: Consider adding a note about recommended configuration method.To help users make an informed decision, consider adding a note about the recommended configuration method. For example:
## Configuration by YAML +{% note %} +While YAML configuration is supported for backward compatibility, the recommended way to configure the ADS integration is through the UI using the configuration flow. +{% endnote %} + To enable ADS, add the following lines to your {% term "`configuration.yaml`" %} file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/ads.markdown
(2 hunks)
🔇 Additional comments (3)
source/_integrations/ads.markdown (3)
14-14
: LGTM! Configuration flow enabled correctly.
The addition of ha_config_flow: true
properly enables the UI-based configuration for the ADS integration.
44-44
: LGTM! Standard config flow documentation included.
The inclusion of the standard configuration flow template follows Home Assistant's documentation standards.
47-47
: LGTM! Clear distinction between configuration methods.
The updated header "Configuration by YAML" clearly distinguishes the YAML configuration method from the new UI-based configuration.
Proposed change
Added a Configuration flow to the ADS integration. Hub can be set up from the frontend.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation