-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Google Cast audio devices as speakers #73832
Conversation
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( |
I believe the correct would be to set Device Class to Speaker only, but for some reason, this does not cause the UI to show the speaker icon. Multiple other integrations also set the speaker icon directly, most likely for the same reason. |
bf4e643
to
08357e5
Compare
Let's open up an issue @ the frontend or, even better, fix the frontend in that case. Working around it; will not improve the situation. |
@frenck you are right. I updated the PR to only set the I'm now also only setting |
640bc06
to
bbf6ef9
Compare
The frontend PR: home-assistant/frontend#12997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @felipecrs 👍
This needs a test, can you please open a PR which adds one @felipecrs ? |
Breaking change
Proposed change
This will set proper icons to Google Cast audio-only devices, making it easier to distinguish TVs from Nest Minis for example.
As in YouTube Music app:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: