Add input_boolean domain to actuator switch selector #131144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While setting up a virtual generic thermostat helper, I couldn’t select an `input_boolean` as an actuator switch to trigger multiple actions. Although I could manually configure it in the YAML, the helper interface only displayed entities from the fan and switch domains. I’ve added support for `input_boolean` entities to enhance this functionality.
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-needed
integration: generic_thermostat
new-feature
small-pr
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
Quality Scale: No score
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
epenet
requested changes
Nov 21, 2024
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| import voluptuous as vol | |||
|
|
|||
| from homeassistant.components import fan, switch | |||
| from homeassistant.components import fan, switch, input_boolean | |||
| @@ -38,7 +38,7 @@ | |||
| ) | |||
| ), | |||
| vol.Required(CONF_HEATER): selector.EntitySelector( | |||
| selector.EntitySelectorConfig(domain=[fan.DOMAIN, switch.DOMAIN]) | |||
| selector.EntitySelectorConfig(domain=[fan.DOMAIN, switch.DOMAIN, input_boolean.DOMAIN]) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
While setting up a virtual generic thermostat helper, I couldn’t select an
input_booleanas an actuator switch to trigger multiple actions. Although I could manually configure it in the YAML, the helper interface only displayed entities from the fan and switch domains. I’ve added support forinput_booleanentities to enhance this functionality.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: