Add a test to introduce compose screenshot testing #4835
+72
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stumbled upon the following page and thought it might be good to add these tests to ensure we dont break the UI, for now a very simple test to compare the entity list just to provide a concept. I like the ease of use of the compose screenshot tool as it plays very very nice with our existing previews. Wear OS first as we have seen the alpha compose builds break things. I think it might be nice to add tests for all of our previews so we can use them more. One thing to consider is that we may need to duplicate the preview code so we can continue to see the previews wehn editing the file. Maybe there is a better way I am not seeing but for now I copied a very simple preview for this.
https://developer.android.com/studio/preview/compose-screenshot-testing
open to suggestions also wanted to submit the action to see how it flows.
Screenshots
Example report:
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
If this is approach is acceptable then the readme should be updated here to help contributors understand how to update reference images if they need to.