Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ceros full width #1035

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Make ceros full width #1035

merged 4 commits into from
Aug 9, 2023

Conversation

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/applications/gene-editing-with-crispr-engineering PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@andreituicu
Copy link
Collaborator

@alexcarol did you check if the other pages still look ok? can you check with Meghna, please?

My thinking is: Since she did not report the other pages, only on this one, I'm guessing that the others are ok. maybe we need a bigger variant just for that page, maybe we introduce a variant. I don't know if it is safe to change the size globally for all pages.

@duynguyen
Copy link
Collaborator

I found at least one page that looks broken: https://issue-1029--moleculardevices--hlxsites.hlx.page/service-support/lab-automation-solutions/lab-automation-for-high-content-screening
It would be safer to add a style for full width / height instead.

@alexcarol
Copy link
Collaborator Author

Good catch, fixed.

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/applications/gene-editing-with-crispr-engineering PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/applications/gene-editing-with-crispr-engineering PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/applications/gene-editing-with-crispr-engineering PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/applications/gene-editing-with-crispr-engineering PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/applications/gene-editing-with-crispr-engineering PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/applications/gene-editing-with-crispr-engineering PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@alexcarol alexcarol merged commit ca4c4ad into main Aug 9, 2023
2 of 3 checks passed
@alexcarol alexcarol deleted the issue-1029 branch August 9, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ceros full width
3 participants