Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1031 - decorate italic video link as button #1033

Merged
merged 3 commits into from
Aug 9, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ export function decorateLinks(main) {
// decorate video links
if (isVideo(url) && !link.closest('.block.hero-advanced') && !link.closest('.block.hero')) {
const closestButtonContainer = link.closest('.button-container');
if (link.closest('.block.cards') || (closestButtonContainer && closestButtonContainer.querySelector('strong'))) {
if (link.closest('.block.cards') || (closestButtonContainer && (closestButtonContainer.querySelector('strong') || closestButtonContainer.querySelector('em')))) {
alinarublea marked this conversation as resolved.
Show resolved Hide resolved
videoButton(link.closest('div'), link, url);
} else {
const up = link.parentElement;
Expand Down