Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solutions header fix for css #392

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Solutions header fix for css #392

merged 3 commits into from
Oct 31, 2024

Conversation

chandans1316
Copy link
Collaborator

@chandans1316 chandans1316 commented Oct 31, 2024 •
edited by joehanchoi
Loading

Issue

Fixes:

Description

Issue with the solution header on desktop.

Test URLs

URL for testing:

Test Description

Fixed the header layout issue, and it does not impact other headers.

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 31, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 31, 2024 •
edited
Loading

Page Scores Audits Google
📱 /campaigns/curam/finland PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /campaigns/curam/finland PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@joehanchoi
Copy link
Collaborator

Happy to state that we finally have access back!

keith-kaplan
keith-kaplan approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@keith-kaplan keith-kaplan merged commit 74670ee into main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-kaplan keith-kaplan keith-kaplan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chandans1316 @joehanchoi @keith-kaplan @chandan-bt