Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Contact Block with Playbook #390

Merged
merged 17 commits into from
Aug 12, 2024
Merged

New Contact Block with Playbook #390

merged 17 commits into from
Aug 12, 2024

Conversation

chandans1316
Copy link
Collaborator

@chandans1316 chandans1316 commented Aug 8, 2024

Issue

Fixes: Form not submitting when Playbook is inactive correctly, adds a new block specifically to Playbook

Description

Validate that you can still submit the form like normal

Test URLs

Test Description

Check the form still submits correctly, the last version you uploaded DID NOT submit the form.

Copy link

aem-code-sync bot commented Aug 8, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 8, 2024

Page Scores Audits Google
/contact1 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@joehanchoi joehanchoi changed the title Playbook logic new block New Contact Block with Playbook Aug 8, 2024
@keith-kaplan
Copy link
Collaborator

@chandans1316 @joehanchoi, we'll test the fast lane functionality, but the page's formatting looks very different from the original contact page.

The column spacing is off and the font sizing is off. What should only change is the form itself and nothing else on the page. Can you please take another stab at this?

Original from (/contact)
image

New from (/contact1)
image

@keith-kaplan
Copy link
Collaborator

@raj-bluetext looks like the latest changes are not rendering correctly, but then realized the author doc block name was marekto-playbook, but the block is called marketo-2. I just updated and it looks like it's rendering correctly now? https://playbook-logic-new-block--merative2--hlxsites.hlx.page/contact1

Will share with Drift colleague to ensure all looks good.

@keith-kaplan keith-kaplan self-requested a review August 12, 2024 14:50
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed as well as Drift team member and internal team member. The Fastlane playbook is firing and is not firing on other forms. Should be good to merge.

@keith-kaplan keith-kaplan merged commit 6f93712 into main Aug 12, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the playbook-logic-new-block branch August 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants