Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Multiple Authors Correctly on Blog Post #382

Merged
merged 1 commit into from
May 6, 2024

Conversation

chandans1316
Copy link
Collaborator

Issue

Fixes: https://merative.atlassian.net/browse/MERATIVE-957

Description

On a blog post on desktop, if there are three authors on a post, the author block goes over the edge of the screen.

Test URLs

Test Description

Instead of being on the same row, a third or fourth author should display on a new line, aligned with the first two authors.

Copy link

aem-code-sync bot commented Apr 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 29, 2024

Page Scores Audits Google
/drafts/Keith/3-author-blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@joehanchoi joehanchoi self-requested a review April 29, 2024 18:56
Copy link
Collaborator

@joehanchoi joehanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bio blocks wrap to new line after two columns

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I tested what would happen if 4 authors were on a post as well and it looks good. https://issue-957-multiple-authors--merative2--hlxsites.hlx.page/drafts/Keith/3-author-blog

I'll approve and merge.

@keith-kaplan keith-kaplan merged commit f0c9399 into main May 6, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the issue-957-Multiple-Authors branch May 6, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants