Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 954 / 955 #371

Closed
wants to merge 15 commits into from
Closed

Issue 954 / 955 #371

wants to merge 15 commits into from

Conversation

Ajeet-Nellikeri
Copy link
Collaborator

@Ajeet-Nellikeri Ajeet-Nellikeri commented Feb 9, 2024

Issue

Fixes https://merative.atlassian.net/browse/MERATIVE-954
Fix : https://merative.atlassian.net/browse/MERATIVE-955

Description

https://merative.atlassian.net/browse/MERATIVE-955

When a content author adds the references block to a blog post, the Unordered lists/numbered lists and list items are not sized correctly. When the references block is removed, this issue gets fixed.

https://merative.atlassian.net/browse/MERATIVE-954

Tertriary button in leadspaces should be center aligned in the leadspace block. Currenlty it is aligned bottom.

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Fixes https://merative.atlassian.net/browse/MERATIVE-954

Fix : https://merative.atlassian.net/browse/MERATIVE-955

Testing Instruction

Open each New URL and inspect the code changes to ensure they render according to the Design Specs in Figma

Note:
The changes are generic and affects all the support pages where "columns" and "leadspace" blocks are used.

Ajeet-Nellikeri and others added 8 commits January 22, 2024 16:22
Inserted addition px data
Updated the code for fixes mentioned in issue 914
Fixes related to Issue 914
content-text-body h5 - merged into one
Text replacement from "..." to "Home"
Spacing re-adjusted to 8 px
MERATIVE-955 and MERATIVE-954
Copy link

aem-code-sync bot commented Feb 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 9, 2024

Page Scores Audits Google
/block-library/templates/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/clinical-decision-support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to issue-855-CustomDriftScript February 29, 2024 07:59 Inactive
@keith-kaplan
Copy link
Collaborator

@chandans1316 i've updated the PR description so it's easier for a user to read and understand what is happening. There needs to be changes made to the https://issue-914--merative2--hlxsites.hlx.page/block-library/templates/blog page. The bulleted lists in the actual body are too small and do not align with the design system specs.

@keith-kaplan keith-kaplan removed the request for review from sachinmesh April 2, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants