Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 914 #370

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Issue 914 #370

merged 7 commits into from
Feb 5, 2024

Conversation

Ajeet-Nellikeri
Copy link
Collaborator

Inserted addition px data
Updated the code for fixes mentioned in issue 914
Fixes related to Issue 914
Copy link

aem-code-sync bot commented Jan 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 22, 2024

Page Scores Audits Google
/support/curam PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

content-text-body h5 - merged into one
Text replacement from "..." to "Home"
Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Spacing between the bullet points to be 8px in Micromedex support page @Ajeet-Nellikeri

CC: @keith-kaplan

Spacing re-adjusted to 8 px
@Ajeet-Nellikeri
Copy link
Collaborator Author

@sachinmesh - Spacing between the bullet points to be 8px in Micromedex fixed

Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing between the bullet text is 8px now as per design. This is good to go @Ajeet-Nellikeri @keith-kaplan

@sachinmesh sachinmesh added Ready to merge Label for the pull requests that are ready to merge and removed 🛠️ fix needed labels Jan 30, 2024
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@keith-kaplan keith-kaplan merged commit 406656d into main Feb 5, 2024
1 of 2 checks passed
@keith-kaplan keith-kaplan deleted the Issue-914 branch February 5, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants