Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zelta page updates #360

Merged
merged 14 commits into from
Dec 5, 2023
Merged

Conversation

nimithshetty17
Copy link

Fixes MERATIVE-927

Description

Design QA feedback on Zelta product family page.

  • Figma Link -

Test URLs

Copy link

aem-code-sync bot commented Nov 28, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Nov 28, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 28, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@nimithshetty17
Copy link
Author

nimithshetty17 commented Nov 28, 2023

@anabarcelona @sachinmesh @keith-kaplan
Below are the issues addressed:-

  1. Fix mis alignment of image bottom is not aligned. - Fixed
  2. Remove divider rule. We don’t need it since we have a color shift. -Fixed
  3. Increase top padding above Explore all case studies to 64px. - Fixed
  4. Please use our short leadspace and remove eyebrow & CTA - Fixed
  5. If we don’t have logos included in our stat component please remove the bottom gray rule - Fixed

Copy link

aem-code-sync bot commented Nov 28, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@nimithshetty17
Copy link
Author

@anabarcelona below issues are addressed.

  1. Screenshot width on tablet should be 10 columns wide - fixed
  2. Also the copyright info needs to match design. looks too big. - fixed
  3. Our navigation and links are missing the animation - fixed
  4. Testimonial top spacing needs to increase to 160px.
  5. Spacing above Explore all case studies needs to decrease to 64px.
    @keith-kaplan @sachinmesh

Copy link

aem-code-sync bot commented Dec 1, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Dec 1, 2023

Page Scores Audits Google
/clinical-development PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are looking good. I looked at a few of our other product family pages and it looks like these changes will cause so re-authoring, but nothing major. It's mostly just re-adding section links dividers. Easy fix with just hopping on a short call and fixing on the fly.

@keith-kaplan keith-kaplan merged commit 37f50d4 into hlxsites:main Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants