-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curam missouri microsite page fixes. #353
Curam missouri microsite page fixes. #353
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
…/nimithshetty17/merative2 into curam-missouri-microsite-changes
|
|
@anabarcelona @sachinmesh @keith-kaplan - These are the following issues addressed in the latest commit:-
|
Hi @nimithshetty17, updated and added comments in the QA doc: Happy to review together next time we meet. It's looking good! |
|
@anabarcelona @keith-kaplan @sachinmesh - Please find the fixes for the new commit below:-
|
Thank @nimithshetty17, I've reviewed and marked things as done! Some are still some remaining things on the list. Thank you :) |
|
@anabarcelona @sachinmesh - The following comments are addressed in the latest commit:-
|
Thanks Nimith once again! We are so close... there are 3 open tasks still remaining in the doc... |
@anabarcelona @sachinmesh - These are the pending changes and the fixes are added in the latest commit:-
|
@nimithshetty17 question on #5 above... who exports the artwork? And where is it saved for the content authors to upload it? |
All the other updates you mentioned above look good! Thanks @nimithshetty17 |
@anabarcelona - We usually get it from Sachin and then the content author will drop the image in the word document. |
@nimithshetty17, okay, sounds like I need to export them and save them. Where are they usually saved? Thank you! |
@anabarcelona - We don't save the images anywhere in Franklin. You can upload it in the Jira ticket or mail it, we'll replace the image. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with Ana and Nimith that is good to get merged.
|
Issue
Fixes #MERATIVE-905
Description
The latest designs for the Missouri campaign in microsite do not match the updated designs in Figma. It is mostly background color changes and addition of headline. The PR consists of fixes for that.
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/drafts/putra/campaigns/missouriTesting Instruction
To test the changes as per the figma link provided above.