Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of a solution block. #350

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

nimithshetty17
Copy link

Fixes #MERATIVE-886

Description

The current name in Franklin for this block is a Teaser List and it only renders if a link is added for each item. We want to make this so it allows for authors to use this layout without links for each item

New

image

Changed

image

Test URLs

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 13, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 13, 2023

Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Only Product logo and name should be thr, not the old name
image
  1. bottom padding if individual then 160px and combined with other component then 96px.

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 16, 2023

Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 16, 2023

Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sachinmesh
Copy link

Extra 160px can be seen below the cards @nimithshetty17

image

@keith-kaplan
Copy link
Collaborator

@nimithshetty17 @sachinmesh please see uses of the solution block in actual pages as well. See here:

https://solution-list-block-new--merative2--nimithshetty17.hlx.page/curam

@sachinmesh
Copy link

@keith-kaplan
Copy link
Collaborator

@nimithshetty17 @sachinmesh I was looking at another page and it looks like there maybe a regression with the latest version. please take a look at screenshot -
image

https://solution-list-block-new--merative2--nimithshetty17.hlx.page/real-world-evidence

@sachinmesh
Copy link

Hi @nimithshetty17 , most of the component, the 160px padding is absent. CC: @keith-kaplan

  1. There should not be any divider line here
image
  1. Here, a margin of 160px should be given above the divider line.
image
  1. Below the illustration 160px margin is needed in bone color.
image
  1. Again, 160px margin is gone here
image
  1. Again here, below the simple content component and the ready to talk CTA 160px margin is absent.
image

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/block-library/blocks/solution-list PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@nimithshetty17
Copy link
Author

@sachinmesh @keith-kaplan - The fix for the above mentioned comments have been added.

@sachinmesh
Copy link

  1. Background color of flexible component should be white and not bone.
image
  1. The margin below the illustration should be 160px.
image

@nimithshetty17 @keith-kaplan

@sachinmesh sachinmesh added Ready to merge Label for the pull requests that are ready to merge and removed 🛠️ fix needed labels Oct 18, 2023
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@keith-kaplan keith-kaplan merged commit a440130 into hlxsites:main Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants