-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of a solution block. #350
Creation of a solution block. #350
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
Extra 160px can be seen below the cards @nimithshetty17 |
@nimithshetty17 @sachinmesh please see uses of the solution block in actual pages as well. See here: https://solution-list-block-new--merative2--nimithshetty17.hlx.page/curam |
This looks good to me |
@nimithshetty17 @sachinmesh I was looking at another page and it looks like there maybe a regression with the latest version. please take a look at screenshot - https://solution-list-block-new--merative2--nimithshetty17.hlx.page/real-world-evidence |
Hi @nimithshetty17 , most of the component, the 160px padding is absent. CC: @keith-kaplan
|
|
@sachinmesh @keith-kaplan - The fix for the above mentioned comments have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Fixes #MERATIVE-886
Description
The current name in Franklin for this block is a Teaser List and it only renders if a link is added for each item. We want to make this so it allows for authors to use this layout without links for each item
New
Changed
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/block-library/blocks/solution-list