-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(references): Add a new block called References #348
feat(references): Add a new block called References #348
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font style all looks good at all breakpoints. Only the Font color should be Neutral 140 which is 5C5A57
@proeung @nimithshetty17 @keith-kaplan
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge. @nimithshetty17 @keith-kaplan @proeung
@nimithshetty17 i'm going to put this on a real blog in the draft folder to test it one more time. |
@sachinmesh can you take a look at this one I updated - https://references-section-block--merative2--nimithshetty17.hlx.page/blog/oncology-research-deserves-cutting-edge-solutions Want to make sure we have an example of this in a real blog post. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nimithshetty17 Looks good, but let's add an empty /blocks/references/references.js
file (eg. https://github.com/hlxsites/merative2/blob/main/blocks/article-quote/article-quote.js) since Franklin expects this in the block creation script (see - https://github.com/hlxsites/merative2/blob/main/scripts/lib-franklin.js#L391) and we can cut on the 404 error.
|
Rest is good to go. @keith-kaplan |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Going to merge. |
Fixes #MERATIVE-825
Description
Create a new block called "References" - /blocks/references with the correct CSS styling that allows for these links to show up properly.
New
Changed
Design Specs
Test URLs
main
): https://main--merative2--nimithshetty17.hlx.page/drafts/nimith/references-blockTesting Instruction