Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(references): Add a new block called References #348

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

nimithshetty17
Copy link

Fixes #MERATIVE-825

Description

Create a new block called "References" - /blocks/references with the correct CSS styling that allows for these links to show up properly.

New

image

Changed

image

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Testing Instruction

To verify the references section block as per design.

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 6, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 6, 2023

Page Scores Audits Google
/drafts/nimith/references-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font style all looks good at all breakpoints. Only the Font color should be Neutral 140 which is 5C5A57

@proeung @nimithshetty17 @keith-kaplan

image

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 10, 2023

Page Scores Audits Google
/drafts/nimith/references-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachinmesh sachinmesh added Ready to merge Label for the pull requests that are ready to merge and removed 🛠️ fix needed labels Oct 10, 2023
@keith-kaplan
Copy link
Collaborator

@nimithshetty17 i'm going to put this on a real blog in the draft folder to test it one more time.

@proeung proeung removed the Ready to merge Label for the pull requests that are ready to merge label Oct 10, 2023
@proeung proeung changed the title References section block. feat(references): Add a new block called References Oct 10, 2023
@keith-kaplan
Copy link
Collaborator

@sachinmesh can you take a look at this one I updated - https://references-section-block--merative2--nimithshetty17.hlx.page/blog/oncology-research-deserves-cutting-edge-solutions

Want to make sure we have an example of this in a real blog post.

Copy link

@proeung proeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimithshetty17 Looks good, but let's add an empty /blocks/references/references.js file (eg. https://github.com/hlxsites/merative2/blob/main/blocks/article-quote/article-quote.js) since Franklin expects this in the block creation script (see - https://github.com/hlxsites/merative2/blob/main/scripts/lib-franklin.js#L391) and we can cut on the 404 error.

Screenshot 2023-10-10 at 9 51 55 AM

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 11, 2023

Page Scores Audits Google
/drafts/nimith/references-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sachinmesh
Copy link

@sachinmesh can you take a look at this one I updated - https://references-section-block--merative2--nimithshetty17.hlx.page/blog/oncology-research-deserves-cutting-edge-solutions

Want to make sure we have an example of this in a real blog post.

  1. Sources text style should be H3 - 32px Source serif pro light
image
  1. Spacing between Heading and body text should be 48px.

Rest is good to go. @keith-kaplan

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 11, 2023

Page Scores Audits Google
/drafts/nimith/references-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@proeung proeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@proeung proeung added Ready to merge Label for the pull requests that are ready to merge and removed 🛠️ fix needed labels Oct 11, 2023
@keith-kaplan
Copy link
Collaborator

Going to merge.

@keith-kaplan keith-kaplan merged commit b5d87a4 into hlxsites:main Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants