-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(microsite): Add Solution Header and Solution Footer blocks used within custom campaign/microsites #344
Conversation
…t-solution-header
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@sachinmesh I just pushed up a commit to address some of the spacing and logo size issues that you mentioned above. As for the height of the borderline on the sticky nav scroll and the gradient on the scroll, let's discuss that on our next design call. I have some concerns about the feasibility given the current timeline and dev resources. cc: @aavilamer https://javascript.plainenglish.io/how-to-create-horizontal-vertical-scroll-shadows-26aa7a7f00a0 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@proeung just took a look and this looks solid.
@keith-kaplan Great! Just need @sachinmesh to re-review/approve and this PR is ready for merge unless there are additional changes. |
Issue
Fixes https://merative.atlassian.net/browse/MERATIVE-878 & https://merative.atlassian.net/browse/MERATIVE-879
Description
New
/blocks/solution-header
- This block manages and displays the anchor/table of contents navigation used on a single campaign/microsite./blocks/solution-footer
- This block manages and displays fragment/related content (See -website > fragments > footer > footer-small
) (see link) for the custom footer.Changed
Design Specs
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/drafts/putra/campaigns/missouriTesting Instruction