Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microsite): Add Solution Header and Solution Footer blocks used within custom campaign/microsites #344

Merged
merged 11 commits into from
Oct 5, 2023

Conversation

proeung
Copy link

@proeung proeung commented Sep 27, 2023

Issue

Fixes https://merative.atlassian.net/browse/MERATIVE-878 & https://merative.atlassian.net/browse/MERATIVE-879

Description

New

  • Solution Header /blocks/solution-header - This block manages and displays the anchor/table of contents navigation used on a single campaign/microsite.
  • Solution Footer /blocks/solution-footer - This block manages and displays fragment/related content (See - website > fragments > footer > footer-small) (see link) for the custom footer.

Changed

  • Fixes grid container of the CTA block

Design Specs

Test URLs

Testing Instruction

Screenshot 2023-09-29 at 11 44 38 AM
Screenshot 2023-09-29 at 11 44 55 AM
Screenshot 2023-09-29 at 11 44 44 AM

  • Visit the "After" deploy preview and ensure that the behaviors and styles of the Header/Nav and Footer align with the design specs.

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 27, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 27, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung changed the title feat(solution-header): Add custom header block for campaign/microsite feat(microsite): Add Solution Header and Solution Footer blocks used within custom campaign/microsites Sep 29, 2023
@proeung proeung marked this pull request as ready for review September 29, 2023 15:55
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung added Needs design QA PRs on feature requests and new components have to get design approval before merge. Content Entry Update This PR contains update that require content entry changes within Sharepoint Doc labels Sep 29, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Dark grey stroke can seen in the header above the highlighter
image image
  1. In mobile, the seperator line should be 32px height only.
image
  1. on horizontal scroll, gradient is missing
image
  1. Logo should be of 38px height with compared to width, for curam it is, 130X38px

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 3, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung removed the Needs design QA PRs on feature requests and new components have to get design approval before merge. label Oct 3, 2023
@proeung proeung added Needs Re-review This PR requires a re-review from QA and Designers and removed 🛠️ fix needed labels Oct 3, 2023
@proeung
Copy link
Author

proeung commented Oct 3, 2023

@sachinmesh I just pushed up a commit to address some of the spacing and logo size issues that you mentioned above.

As for the height of the borderline on the sticky nav scroll and the gradient on the scroll, let's discuss that on our next design call. I have some concerns about the feasibility given the current timeline and dev resources.

cc: @aavilamer

https://javascript.plainenglish.io/how-to-create-horizontal-vertical-scroll-shadows-26aa7a7f00a0

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 3, 2023

Page Scores Audits Google
/drafts/putra/campaigns/missouri PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proeung just took a look and this looks solid.

@proeung
Copy link
Author

proeung commented Oct 4, 2023

@keith-kaplan Great! Just need @sachinmesh to re-review/approve and this PR is ready for merge unless there are additional changes.

@sachinmesh sachinmesh added Ready to merge Label for the pull requests that are ready to merge and removed Needs Re-review This PR requires a re-review from QA and Designers labels Oct 5, 2023
@keith-kaplan keith-kaplan merged commit c1c2871 into hlxsites:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Entry Update This PR contains update that require content entry changes within Sharepoint Doc Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants