You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.
The reason will be displayed to describe this comment to others. Learn more.
@sahmad-merative Code looks good overall. You just need to resolve some of the lint check issues as well as the alignment/spacing bugs that @sachinmesh mentioned above.
proeung
changed the title
Feature(masthead): Updated Mega-menu to support "Support page" links
feat(masthead): Updated Mega-menu to support "Support page" links
Sep 20, 2023
@proeung The data source has been changed back to the default fragments path, and all the lint issues are also resolved.
This PR is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sahmad-merative
requested review from
proeung,
nimithshetty17,
sachinmesh and
sharathmrft
proeung
changed the title
The purpose of updating the Masthead/Nav Megamenu is to streamline the display of the Support links so that they're easily accessible within the menu.
This PR is only for Frankiln implementation.
Issue MERATIVE-872
Fixes #
Description
The purpose of updating the Masthead/Nav Megamenu is to streamline the display of the Support links so that they're easily accessible within the menu.
This PR is only for Frankiln implementation.
New
Updated Mega-menu to support "Support page" links
Design Specs
Test URLs
main): https://main--merative2--hlxsites.hlx.page/Testing Instruction