New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(csp): allow googlesyndication and doubleclick #336

Merged

proeung merged 3 commits into hlxsites:main from proeung:chore-csp-891

Sep 14, 2023

proeung commented Sep 13, 2023 •

edited

Loading

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-891

Description

Changed

This PR updates both CSPs on Franklin to allow for googlesyndication and doubleclick.net that are part of google ads.

Design Specs

Figma Link - N/A

Test URLs

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/
After (Changes from this PR): https://chore-csp-891--merative2--proeung.hlx.page

Testing Instruction

Visit this deploy preview URL (https://chore-csp-891--merative2--proeung.hlx.page)
Ensure that there's no CSP error in the console
NOTE: Disregard the error from Drift since this is a test Franklin deploy preview.


          chore(csp): allow googlesyndication and doubleclick

6040b4c

aem-code-sync bot commented Sep 13, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-run PSI Checks

aem-code-sync bot commented Sep 13, 2023

Page	Scores	Audits	Google
/


          chore(csp): add doubleclick to frame-src

f548edd

aem-code-sync bot commented Sep 13, 2023

Page	Scores	Audits	Google
/


          chore(csp): add google

09f9911

aem-code-sync bot commented Sep 13, 2023

Page	Scores	Audits	Google
/

proeung requested review from scottbridgeman, keith-kaplan, nimithshetty17 and sharathmrft

September 13, 2023 19:06

proeung added the Chore label

sharathmrft reviewed

View reviewed changes

sharathmrft left a comment

@proeung CSP is allowing google syndication and doubleclick.net but there are other errors are appearing as below.

@nimithshetty17 @keith-kaplan

scottbridgeman approved these changes

View reviewed changes

scottbridgeman left a comment

Changes look great, thank you @proeung

proeung merged commit 2ffc2ad into hlxsites:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Chore