Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quick-links): Add POC LinkTree/Bitly template for showing quick links #318

Merged
merged 10 commits into from
Aug 30, 2023
Merged

feat(quick-links): Add POC LinkTree/Bitly template for showing quick links #318

merged 10 commits into from
Aug 30, 2023

Conversation

proeung
Copy link

@proeung proeung commented Aug 18, 2023 •
edited
Loading

Issue

Fixes - https://jira.sdlc.merative.com/browse/MERATIVE-821

Description

New

  • This PR adds a new template and blocks for showcasing quick links.
  • This is a POC (proof of concept) to quickly leverage Franklin as a means to create helpful links pages that can be used by marketers in conference/event booths. Allowing customers/users to quickly scan the QR code to access helpful links within their mobile devices.
  • NOTE: The design of this template is not finalized. I just put together a layout in code to showcase what the different products will look like in their own branding color and pattern.

Design Specs

  • Figma Link - No design specs

Micromedex - Quick Links

Screenshot 2023-08-25 at 2 51 51 PM

Screenshot 2023-08-25 at 2 50 11 PM

Health Insights - Quick Links

Screenshot 2023-08-25 at 2 51 55 PM
Screenshot 2023-08-25 at 2 50 15 PM

Testing Instruction

  • Visit the preview links above and ensure that the CTA test links are functioning correctly.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 18, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 18, 2023

Page Scores Audits Google
/quick-links/health-insights PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/quick-links/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 18, 2023

Page Scores Audits Google
/quick-links/health-insights PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/quick-links/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung added Needs design QA PRs on feature requests and new components have to get design approval before merge. Needs Stakeholders sign off Merative team sign off labels Aug 18, 2023
@proeung proeung added the On-Hold Work is on-hold until proper sign off label Aug 23, 2023
@proeung
Merge branch 'main' of https://github.com/hlxsites/merative2 into fea…
7fb52cb 
…t-quicklinks-poc

# Conflicts:
#	styles/styles.css
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/quick-links/health-insights PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/quick-links/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/quick-links/health-insights PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/quick-links/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/quick-links/health-insights PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/quick-links/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung removed the On-Hold Work is on-hold until proper sign off label Aug 25, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 30, 2023

Page Scores Audits Google
/quick-links/health-insights PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/quick-links/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung removed Needs design QA PRs on feature requests and new components have to get design approval before merge. Needs Stakeholders sign off Merative team sign off labels Aug 30, 2023
@proeung
Copy link
Author

proeung commented Aug 30, 2023

@aavilamer I just followed up with Erin Fortuna and Caroline Muse to see if there are any upcoming events this template will be good to test out.

In the meantime, I'm going to merge the changes in this PR so that this feature is available for production usage and avoid code merge conflicts. If there are additional changes such as updating the footer patterns, etc. I'll open up a follow-up PR.

@proeung proeung added the Ready to merge Label for the pull requests that are ready to merge label Aug 30, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 30, 2023

Page Scores Audits Google
/quick-links/health-insights PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/quick-links/micromedex PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@proeung proeung merged commit 5c29399 into hlxsites:main Aug 30, 2023
2 checks passed
@proeung proeung mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-kaplan keith-kaplan Awaiting requested review from keith-kaplan

@sachinmesh sachinmesh Awaiting requested review from sachinmesh

@aavilamer aavilamer Awaiting requested review from aavilamer

@scottbridgeman scottbridgeman Awaiting requested review from scottbridgeman

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@proeung