feat(section-Image-flush-bottom ): add image-flush-bottom section. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimithshetty17
added
the
Needs design QA
nimithshetty17
requested review from
proeung,
keith-kaplan,
sachinmesh,
sharathmrft and
sahmad-merative
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
HI,
REst is good to go. |
|
|
@sachinmesh - Please check now. |
sachinmesh
approved these changes
Aug 9, 2023
sachinmesh
added
Ready to merge
|
proeung
suggested changes
Aug 9, 2023
There was a problem hiding this comment.
@nimithshetty17 Looks good! I just have a couple of minor changes.
Let's add empty image-flush-bottom.js file in the blocks/image-flush-bottom/ directory so that we don't see this 404 in the console (see attached).
proeung
added
🛠️ fix needed
and removed
Ready to merge
|
|
@proeung - have done the changes for the same. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #MERATIVE-782
Description
To create a new section and variations for this called "Image band - flush bottom"
New
Design Specs
Test URLs
main): https://main--merative2--nimithshetty17.hlx.page/block-library/sections/section-image-band-flush-bottomTesting Instruction
To test the section image flush bottom with brand logo and its responsiveness with respect to the design across all devices.