Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(content-band-checkmarks): Content band checkmarks block changes #300

Merged
merged 12 commits into from
Aug 11, 2023
Merged

feat(content-band-checkmarks): Content band checkmarks block changes #300

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fa306f1
feat(content-band-list-block): Content checkmarks block changes.
nimithshetty17 Jul 27, 2023
7938bcc
Merge branch 'main' into section-content-band-checkmarks
proeung Jul 31, 2023
1acf1bc
feat(content-band-list-block): Content checkmarks width changes.
nimithshetty17 Aug 3, 2023
3cb6f4d
Merge branch 'main' into section-content-band-checkmarks
proeung Aug 3, 2023
8e93521
Merge branch 'main' into section-content-band-checkmarks
proeung Aug 9, 2023
27199fa
feat(content-band-list-block): variable name additions.
nimithshetty17 Aug 10, 2023
39bde8d
Merge branch 'main' into section-content-band-checkmarks
proeung Aug 10, 2023
1cf5989
feat(content-band-list-block): content checkmarks block vide implemen…
nimithshetty17 Aug 11, 2023
9825e7b
feat(content-band-list-block): styles css lint fix.
nimithshetty17 Aug 11, 2023
28d67c1
Update blocks/content-band-checkmarks/content-band-checkmarks.css
proeung Aug 11, 2023
8e20e94
Update blocks/content-band-checkmarks/content-band-checkmarks.css
proeung Aug 11, 2023
4230dc2
Merge branch 'main' into section-content-band-checkmarks
proeung Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 130 additions & 0 deletions blocks/content-band-checkmarks/content-band-checkmarks.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
.content-band-checkmarks > div > div:first-child > p:first-child {
font-family: var(--sans-serif-font-medium);
font-size: var(--font-size-11);
font-weight: var(--font-weight-medium);
line-height: var(--line-height-120);
letter-spacing: var(--letter-spacing-02-em);
margin: 0 0 var(--spacer-element-07) 0;
}

.content-band-checkmarks > div > div:first-child > h2 {
font-family: var(--serif-font);
font-size: var(--font-size-32);
font-weight: var(--font-weight-light);
line-height: var(--line-height-120);
letter-spacing: var(--letter-spacing-1-75);
margin: 0 0 var(--spacer-element-08) 0;
}

.content-band-checkmarks > div > div:first-child > p:not(:first-child):not(.button-container) {
font-family: var(--sans-serif-font-light);
font-size: var(--font-size-16);
font-weight: var(--font-weight-light);
line-height: var(--line-height-160);
letter-spacing: var(--letter-spacing-001-em);
margin: 0 0 var(--spacer-element-08) 0;
}

.content-band-checkmarks > div > div:first-child > .button-container {
margin: 0 0 var(--spacer-layout-04);
}

.content-band-checkmarks > div > div:first-child > .button-container>strong>a {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.content-band-checkmarks > div > div:first-child > .button-container>strong>a {
.content-band-checkmarks > div > div:first-child > .button-container > strong > a {

font-family: var(--sans-serif-font-medium);
font-size: var(--font-size-16);
font-weight: var(--font-weight-medium);
line-height: var(--line-height-160);
letter-spacing: 0.16px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
letter-spacing: 0.16px;
letter-spacing: var(--letter-spacing-001-em);

padding: 16px var(--spacer-element-07);
proeung marked this conversation as resolved.
Show resolved Hide resolved
}

.content-band-checkmarks > div > div:nth-child(2) > ul {
margin: 0;
padding: 0;
}

.content-band-checkmarks > div > div:nth-child(2) > ul>li {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.content-band-checkmarks > div > div:nth-child(2) > ul>li {
.content-band-checkmarks > div > div:nth-child(2) > ul > li {

font-family: var(--sans-serif-font-medium);
font-size: var(--font-size-18);
font-weight: var(--font-weight-medium);
line-height: var(--line-height-160);
letter-spacing: var(--letter-spacing-001-em);
margin: 0 0 16px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin: 0 0 16px;
margin: 0 0 var(--spacer-element-05);

padding: 0 24px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
padding: 0 24px;
padding: 0 var(--spacer-element-07);

height: 48px;
proeung marked this conversation as resolved.
Show resolved Hide resolved
display: flex;
align-items: center;
}

main > .section.section-header.list-section.bg-neutral-bone > .content-band-checkmarks-wrapper > .content-band-checkmarks > div > div:nth-child(2) > ul>li {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
main > .section.section-header.list-section.bg-neutral-bone > .content-band-checkmarks-wrapper > .content-band-checkmarks > div > div:nth-child(2) > ul>li {
main > .section.section-header.list-section.bg-neutral-bone > .content-band-checkmarks-wrapper > .content-band-checkmarks > div > div:nth-child(2) > ul > li {

background-color: white;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background-color: white;
background-color: var(--neutral-white);

}

.content-band-checkmarks > div > div:nth-child(2) > ul>li::before {
margin-right: 24px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin-right: 24px;
margin-right: var(--spacer-element-07);

}


/* Tablet CSS */
@media (min-width: 768px) {
.content-band-checkmarks > div > div:first-child > h2 {
max-width: 516px;
}

.content-band-checkmarks > div > div:first-child > p:not(:first-child):not(.button-container) {
max-width: 517px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the max-width value to 516px so that we don't have just one pixel off.

.content-band-checkmarks > div > div:first-child > h2,
.content-band-checkmarks > div > div:first-child > p:not(:first-child):not(.button-container) {
   max-width: 516px;
}

}

.content-band-checkmarks > div > div:nth-child(2) > ul {
display: grid;
grid-template-columns: repeat(2, 1fr);
grid-template-rows: repeat(3, 1fr);
grid-auto-flow: column;
column-gap: 24px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
column-gap: 24px;
column-gap: var(--gap-24);

Let's move this into CSS variable (--gap-24: 24px;). https://github.com/hlxsites/merative2/blob/main/styles/styles.css#L196

}

}

/* Desktop css */
@media (min-width: 1200px) {
.content-band-checkmarks > div {
display: flex;
gap: 120px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gap: 120px;
gap: var(--gap-120);

see - https://github.com/hlxsites/merative2/blob/main/styles/styles.css#L198C3-L198C12

}

.content-band-checkmarks > div > div:first-child {
max-width: 644px;
}

.content-band-checkmarks > div > div:first-child > p:first-child{
font-size: var(--font-size-14);
letter-spacing: var(--letter-spacing-02-em);
}

.content-band-checkmarks > div > div:first-child > h2 {
font-size: var(--font-size-45);
letter-spacing: var(--letter-spacing-1-75);
max-width: 100%;
}

.content-band-checkmarks > div > div:nth-child(2) > ul>li {
font-size: var(--font-size-21);
height: 64px;
width: 360px;
}

.content-band-checkmarks > div > div:first-child > p:not(:first-child):not(.button-container) {
font-size: var(--font-size-21);
letter-spacing: var(--letter-spacing-001-em);
max-width: 100%;
}

.content-band-checkmarks>div>div:nth-child(2) {
max-width: 360px;
}

.content-band-checkmarks > div > div:nth-child(2) > ul {
display: block;
}

}