Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in cmake support and providing statically linked + interface l… #24

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

phelter
Copy link

@phelter phelter commented Nov 25, 2022

Provide CMake Support and a method via cmake to support multiple implementations of the same library by separating out the INTERFACE and multiple STATIC libraries.

@phelter phelter force-pushed the feature/cmake-and-interface-lib-support branch from 24322a8 to 3875aeb Compare November 25, 2022 22:58
@phelter
Copy link
Author

phelter commented Jan 22, 2023

@hjagodzinski - Could you please look into merging this and/or identify whether you are willing to maintain these changes.

@hjagodzinski
Copy link
Owner

I have not been coding in C/C++ for many years now which makes maintaining this project difficult for me. I would rather keep it as simple as possible. I'm more than open to leaving references to your work in whatever form you prefer: a gist, another project, or an article. You could then freely manage your work and I would not have to maintain a more complex project.

@phelter
Copy link
Author

phelter commented Apr 24, 2023

So the answer is No ? I was hoping that you'd be willing to merge into your repo so that I wouldn't have to maintain a fork. But if that isn't in the cards then that is fine. I'll keep my fork of this repo around for my use. Thank you for sharing the original.

Can you please merge if you are willing to take on the work OR Close with out merge to reject it, and I'll consider this repo no longer maintaned, and work around that.

Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants