Add support for splice plugin with GHC 9.10 #4452
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just seen @alanz on Matrix say:
So maybe it's worth waiting one more version before spending too much time on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping that we might get this plugin back for the upcoming release (#4448), but unfortunately it's not completely straightforward. The code compiles with no changes, but the test outputs in a few cases are slightly wrong, generally around leading and trailing whitespace and parentheses.
I spent a few hours looking in to this last weekend, but I'm over my head. I think someone with more experience with the GHC API and
ghc-exactprintis going to have to take over. I'm putting my WIP stuff here just in case it's of use.