Update wasm bindists #173
Update wasm bindists #173
Conversation
| @@ -27,30 +27,29 @@ ghcupDownloads: | |||
| dlUri: https://downloads.haskell.org/~ghcup/unofficial-bindists/ghc/javascript-unknown-ghcjs-9.6.2/ghc-javascript-unknown-ghcjs-9.6.2-aarch64-apple-darwin.tar.xz | |||
| dlHash: 0d65bb3940a820d95b4b33ea0cd61bf39670d48c4d8f747153ded01a7ef34821 | |||
| dlSubdir: ghc-9.6.2-javascript-unknown-ghcjs | |||
| wasm32-wasi-9.6.3.20230927: | |||
| wasm32-wasi-9.6.4: | |||
There was a problem hiding this comment.
The old bindists must be used with an old wasi-sdk, since our recent update in the toolchain contains ABI breaking change. Given the official installation guide still uses ghc-wasm-meta's master branch which will contain the new toolchain, it makes sense to simply replace the old bindists.
There was a problem hiding this comment.
The idea generally in ghcup is to be append only.
We can print a post-install message to tell users to use a specific ghc-wasm-meta commit to use with the bindist version.
There was a problem hiding this comment.
I see. I appended to the legacy bindists now.
There was a problem hiding this comment.
What is the ghc-wasm-meta commit that will work?
There was a problem hiding this comment.
til viPostInstall, thanks and i'll push the change later. where is this metadata documented, may i ask?
There was a problem hiding this comment.
There's no comprehensive documentation about it.
You basically have to follow the types: https://github.com/haskell/ghcup-hs/blob/190d308ddf4a95f2024f9fc3ca8a1f14d3f62711/lib/GHCup/Types.hs#L76-L81
We tried to do a json schema once, but that stalled.
There was a problem hiding this comment.
I just noticed that post-install is not really appropriate, because you need the wasm environment sourced before installing the cross GHC. We need pre install message. I'll have to add that as a new feature for the next release.
There was a problem hiding this comment.
docs change: haskell/ghcup-hs#1017
TerrorJack
force-pushed
the
update-wasm
branch
from
9fd3073
to
9be7c1c
Compare
@hasufell If you wouldn't mind, I'm counting on you to sign the yaml payload here :)