Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pre-install messages #1016

Closed
hasufell opened this issue Mar 2, 2024 · 2 comments
Closed

Add support for pre-install messages #1016

hasufell opened this issue Mar 2, 2024 · 2 comments
Labels
level: good first issue type: improvement
Milestone
0.1.22.0

Comments

@hasufell
Copy link
Member

hasufell commented Mar 2, 2024 •
edited
Loading

Right now we have only:

ghcup-hs/lib/GHCup/Types.hs

Lines 151 to 154 in 190d308

-- informative messages
, _viPostInstall :: Maybe Text
, _viPostRemove :: Maybe Text
, _viPreCompile :: Maybe Text

We need pre install messages for cross bindists: https://github.com/haskell/ghcup-metadata/pull/173/files#r1509886286
@hasufell hasufell added this to the 0.1.22.0 milestone Mar 2, 2024
@hasufell hasufell mentioned this issue Mar 2, 2024
Merged
@hasufell
Copy link
Member Author

hasufell commented Mar 2, 2024

Related docs change: #1017

hasufell added a commit that referenced this issue Mar 2, 2024
@hasufell
Add viPreInstall wrt #1016
077cfff
@hasufell hasufell changed the title Add support for post-install messages Add support for pre-install messages Mar 2, 2024
@hasufell
Copy link
Member Author

hasufell commented Mar 2, 2024

#1018

hasufell added a commit that referenced this issue Mar 2, 2024
@hasufell
Add viPreInstall wrt #1016
d94b7c4
hasufell added a commit that referenced this issue Mar 2, 2024
@hasufell
Add viPreInstall wrt #1016
aef10a6
@fishtreesugar fishtreesugar mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
level: good first issue type: improvement
Projects
None yet
Milestone
0.1.22.0
Development

No branches or pull requests
1 participant
@hasufell