Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp Breadcrumbs for v2 #472

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Temp Breadcrumbs for v2 #472

wants to merge 2 commits into from

Conversation

vivek-harness
Copy link
Contributor

IMPORTANT:

  • In this PR, Breadcrumbs is USING IMPORTS FROM CANARY & VIEWS, so ideally we should not have it in V2
  • Later, the Breadcrumbs component need to be replaced with the new component that the PP team provides.
  • Right now, it is being included here as a TEMP solution until we get the new Breadcrumb component

With this PR, Breadcrumbs shall only work for V2 routes.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 24a2d12
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67410490713a6d000803662e
😎 Deploy Preview https://deploy-preview-472--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sans-harness
Copy link
Contributor

I think we should leave this open until confirmation from @abhinavrastogi-harness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants