chore: Fix type issue for list principals #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cjlee01
reviewed
Nov 13, 2024
| @@ -58,8 +58,7 @@ export default function PullRequestConversationPage() { | |||
| const [checkboxBypass, setCheckboxBypass] = useState(false) | |||
| const { spaceId, repoId } = useParams<PathParams>() | |||
| const { data: { body: principals } = {} } = useListPrincipalsQuery({ | |||
| // @ts-expect-error : BE issue - not implemnted | |||
| queryParams: { page: 1, limit: 100, type: 'user' } | |||
| queryParams: { page: 1, limit: 100, type: ['user'] } | |||
There was a problem hiding this comment.
when api call is made it doesn't work when
type: ['user']
cjlee01
reviewed
Nov 13, 2024
| // @ts-expect-error - api call shows the array type but if we dont use the string type it will throw error | ||
| queryParams: { page: 1, limit: 20, type: 'user' } | ||
| // api call shows the array type but if we dont use the string type it will throw error | ||
| queryParams: { page: 1, limit: 20, type: ['user'] } |
cjlee01
reviewed
Nov 13, 2024
| @@ -50,8 +50,7 @@ export const RepoBranchSettingsRulesPageContainer = () => { | |||
| ) | |||
|
|
|||
| const { data: { body: principals } = {}, error: principalsError } = useListPrincipalsQuery({ | |||
| // @ts-expect-error : BE issue - not implemnted | |||
| queryParams: { page: 1, limit: 100, type: 'user' } | |||
| queryParams: { page: 1, limit: 100, type: ['user'] } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.