Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs from missing translations #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bugs from missing translations #161

wants to merge 1 commit into from

Conversation

samuelcalegari
Copy link

Fix bugs from missing translations
prevent error in console : Uncaught TypeError: translation[i] is undefined
when add an interactive video in branching scenario in french

@matthiasblaesing
Copy link

I think this is a duplicate of #159, which is an independend implementation of the idea proposed in this issue: #157.

Contrary to the claim in #157 I still think this is a problem in h5p-editor-php-library, which can get into an unusable state when the translation data is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelcalegari @matthiasblaesing