-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L103 Draft: Add Types to the remainder of the gRPC Python API Surface #337
base: master
Are you sure you want to change the base?
Conversation
compression: Optional[Compression] = None) -> ResponseType: | ||
``` | ||
|
||
## Implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once it exists, the implementation PR should be linked to here.
* Status: Draft | ||
* Implemented in: Python | ||
* Last updated: 11/09/2022 | ||
* Discussion at: <google group thread> (filled after thread exists) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to create the Google group thread once the gRFC is in a presentable state.
* [PR1: Add typing for some internal python files.](https://github.com/grpc/grpc/pull/31514) | ||
* Add typing to public API and test though pre-release. | ||
* [PR link holder] | ||
* Release typed public APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to the current contents. Now you'll want to:
- Start the implementation PR
- Link the implementation PR from this gRFC
- Post the gRFC in the grpc-io Google group
- Complete the implementation
- After 2 weeks, merge the gRFC
- Merge the implementation
No description provided.