Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L103 Draft: Add Types to the remainder of the gRPC Python API Surface #337

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

XuanWang-Amos
Copy link
Contributor

No description provided.

L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
compression: Optional[Compression] = None) -> ResponseType:
```

## Implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once it exists, the implementation PR should be linked to here.

* Status: Draft
* Implemented in: Python
* Last updated: 11/09/2022
* Discussion at: <google group thread> (filled after thread exists)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to create the Google group thread once the gRFC is in a presentable state.

L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
@gnossen gnossen changed the title L103 Draft: Add Typing to gRPC Python Sync APIs L103 Draft: Add Types to the remainder of the gRPC Python API Surface Nov 10, 2022
L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
L103-python-add-typing-to-sync-api.md Outdated Show resolved Hide resolved
* [PR1: Add typing for some internal python files.](https://github.com/grpc/grpc/pull/31514)
* Add typing to public API and test though pre-release.
* [PR link holder]
* Release typed public APIs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider writing a blog post about this on grpc.io once it's finished.

CC @tmwilson

Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to the current contents. Now you'll want to:

  • Start the implementation PR
  • Link the implementation PR from this gRFC
  • Post the gRFC in the grpc-io Google group
  • Complete the implementation
  • After 2 weeks, merge the gRFC
  • Merge the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants