Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROOVY-6675 : Base script support for JCommander annotation-based parameters #371

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jimwhite
Copy link
Contributor

@jimwhite jimwhite commented Apr 6, 2014

As the jira explains [http://jira.codehaus.org/browse/GROOVY-6675], we need a base script in Groovy to support super cool declarative scripts that use annotations to define the argument parsing into parameters. The base script is groovy.cli.JCommanderScript which provides JCommander annotations which we use because Apache CLI doesn't have any yet. JCommander is already in Groovy because of TestNG so we put this class there so that it doesn't change anything for folks that don't have/want JCommander.

This PR also bumps TestNG to 6.8.8 and JCommander to 1.35.

@jimwhite
Copy link
Contributor Author

Refined API for multiple command dispatching and many other fussy details to cover every possible initialization scenario. Also a goodly dose of Javadoc. A blog post or somesuch will be forthcoming.

Note also that since this version now lives in groovy-cli, this PR also represents progress on [https://jira.codehaus.org/browse/GROOVY-6624].

@melix
Copy link
Member

melix commented May 30, 2014

Hi Jim!

Could you give us a bit of status update wrt to this PR and the associated tickets? Is that ready for merge?

@jimwhite
Copy link
Contributor Author

I expect that the PR is out-of-date by now, especially since Paul did some work on 6624 which needs to be merged with this. I should be able to get current with master and update the PR on Monday or Tuesday.

…ds are called Subcommand now and exit codes are handled.
@jimwhite
Copy link
Contributor Author

I take that back. Looks like 6624 has more work to do and the lights are still green here. I've merged a couple tweaks from using this in Gondor development. It's all good to go from my perspective.

traneHead pushed a commit to traneHead/groovy-core that referenced this pull request Jul 29, 2017
…roovy#433)

Fixes or partially addresses the following:

GROOVY-6699: ignore properties/fields during serialization
GROOVY-6854: serialize ISO-8601 dates
GROOVY-6975: deactivate unicode escaping
GROOVY-7682: JodaTime/JSR310 (using custom converter)
GROOVY-7780: exclude null values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants