Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 18 migration #201

Closed
wants to merge 7 commits into from
Closed

Conversation

msibhuiyan
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other : Update deps version

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Migrated to angular 17 and upgraded peerdependencies of core and
keepalive to angular 17

BREAKING CHANGE: 🧨 New angular version upgradation
Exposed providers array from module files
Used standalone component in docs example

BREAKING CHANGE: 🧨 Remvoed regular component and App Module, Introduced AppConfig to
configure necessary services
Fixed test running issue for docs
Angular 17 starts with minimum of node 18
Angular and Angular material migrated from 17 to 18
Keepalive test with new angular implementation
@grbsk
Copy link
Owner

grbsk commented Jun 21, 2024

Hi, @BhuiyanSaif18. @ng-idle/core and keepalive 15 w/ Angular 17 support are out the door, again, thanks. Naturally, however, that means there are some merge conflicts since I squashed and merged. I'd rebase off the latest master and try again.

@grbsk grbsk closed this Jun 21, 2024
@hey24sheep
Copy link

@BhuiyanSaif18 can you generate a fresh PR for Angular 18 as well that will be great. Again, thanks for your help. Appreciate it a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants