Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github.com/ghodss/yaml with sigs.k8s.io/yaml #23109

Closed
wants to merge 1 commit into from
Closed

Replace github.com/ghodss/yaml with sigs.k8s.io/yaml #23109

wants to merge 1 commit into from

Conversation

Juneezee
Copy link

The package github.com/ghodss/yaml is no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

@github-actions github-actions bot added database-access Database access related issues and PRs size/sm tctl tctl - Teleport admin tool tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Mar 15, 2023
@strideynet
Copy link
Contributor

strideynet commented Mar 15, 2023

We also use gopkg.in/yaml.v2 in some places, I think it's worth us evaluating if it's worth switching github.com/ghodss/yaml to that instead rather than swapping to the k8s maintained package. That way we'd finally be down to a single yaml package in use within the main module of the Teleport codebase.


Ah right, it completely skipped my brain that github.com/ghodss/yaml actually wraps gopkg.in/yaml.v2 in order to provide compatibility with JSON field tags and marshal/unmarshal methods.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee Juneezee closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database-access Database access related issues and PRs size/sm tctl tctl - Teleport admin tool tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants