Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial changes for Event Streams #1099

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Editorial changes for Event Streams #1099

wants to merge 2 commits into from

Commits on Jun 11, 2024

  1. Editorial changes for Event Streams 

    This makes a few changes to the Subscriptions section where we're
talking about event streams in an attempt to make it more clear about
what's going on.

- Revised variable names from "fieldStream" to "sourceStream" to make it
  easier to trace variables through algorithms.

- Rewrote the "Event Streams" definition to be more clear about "emit"
  keyword and have clear paragraphs on completion and cancellation.

- Rewrote the `MapSourceToResponseEvent` algorithm to be a correctly
  formatted algorithm with a return statement at the end. Introduced a
  new "When" keyword to describe event subscriptions. Added explicit
  sections on passing back cancellation (discussed in WG) as well as
  completion with error (not discussed, but I realized was also left
  ambiguous)
    @leebyron
    leebyron committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5bb1e07 View commit details
    Browse the repository at this point in the history

  2. feedback and use definition syntax

    @leebyron
    leebyron committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    75f10e0 View commit details
    Browse the repository at this point in the history