Apply suggestion

Co-Authored-By: yaacovCR <[email protected]>
graphql · Jun 19, 2024 · 516cfd2 · 516cfd2
1 parent f6fd3cf
commit 516cfd2
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts b/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts
@@ -494,15 +494,18 @@ const processDiscoveredFragments = (
   fieldMap: NodeAndDefCollection,
   discoveredFragments: Array<Array<string>>,
 ) => {
-  while (discoveredFragments.length !== 0) {
-    const item = discoveredFragments.pop();
+  let item;
+  while ((item = discoveredFragments.pop()) !== undefined) {
+    const [fragmentName, referencedFragmentName] = item;
     if (
-      !item ||
-      comparedFragmentPairs.has(item[1], item[0], areMutuallyExclusive)
+      comparedFragmentPairs.has(
+        referencedFragmentName,
+        fragmentName,
+        areMutuallyExclusive,
+      )
     ) {
       continue;
     }
-    const [fragmentName, referencedFragmentName] = item;
     comparedFragmentPairs.add(
       referencedFragmentName,
       fragmentName,