-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update middleware with options and new design #774
Conversation
If we merge #773 then it will reduce the diff here in this PR. Most changed files in this PR have file-scoped namespaces. |
@sungam3r This PR is a copy of my implementation with almost no changes. I have commented out the code that is needed to support websockets once we merge the updated websocket support. Until then it will still use the old websocket middleware. If we want to make changes here, we should make them in a separate PR. For instance, if we want to reintroduce the CancellationToken virtual member (which is fine; it will not significantly change the code), let's make a separate PR to do so. I want to keep track of the diff between this and GraphQL.AspNetCore3. |
The few changes to tests involve mutation requests against a GET endpoint, and error message results. |
Need to update branch? Will nothing bad happen? |
@Shane32 Check description of https://github.com/graphql-dotnet/server/milestone/7 |
I do not promise that I can review tomorrow. I had a challenge at work so most likely on the weekend. |
src/Transports.AspNetCore/Extensions/GraphQLBuilderMiddlewareExtensions.cs
Show resolved
Hide resolved
src/Transports.AspNetCore/Extensions/GraphQLHttpApplicationBuilderExtensions.cs
Show resolved
Hide resolved
Co-authored-by: Ivan Maximov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #774 +/- ##
===========================================
- Coverage 47.80% 47.58% -0.23%
===========================================
Files 50 59 +9
Lines 1548 1715 +167
Branches 174 204 +30
===========================================
+ Hits 740 816 +76
- Misses 752 822 +70
- Partials 56 77 +21
Continue to review full report at Codecov.
|
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Co-authored-by: Ivan Maximov <[email protected]>
Finished! I resolved all conversation except one with subscriptions/websockets explanations as a reminder for me to read later. |
TODO
BatchedRequestsExecuteInParallel
in some batching docs/specsBatchedRequestsConcurrencyLimit
as a new feature in a separate PR or here.GraphQLRequestExecutionResult