Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clientMutationId and use React Spa Template for .NET 6 #120

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fiyazbinhasan
Copy link

@Shane32 I just made some changes based on this issue, #106

@Shane32
Copy link
Member

Shane32 commented Jul 19, 2021

.NET 6 has not been released yet. Is there so much difference that we cannot use the .NET 5 server for the SPA? It should be fine if the SPA itself is based on the .NET 6 template.

@Shane32
Copy link
Member

Shane32 commented Jul 19, 2021

It looks like .NET 6 is scheduled for release in November. Not that far away.

@fiyazbinhasan
Copy link
Author

Hi @Shane32! Only the todo spa app is based on .net 6. I think it is far easier to use this template than to manage the react app yourself (webpack). What do you think?

@Shane32
Copy link
Member

Shane32 commented Jul 20, 2021

Certainly don’t want to manage the spa setup but if the .NET csproj targets .NET 5 rather than .NET 6 most likely everything else (such as create-react-app, which does the webpack setup) can stay the same.

@fiyazbinhasan
Copy link
Author

Microsoft.AspNetCore.SpaProxy API is part of .NET 6. I can come back here later and update the todo app if anything breaks or we can wait till November

@Shane32
Copy link
Member

Shane32 commented Jul 20, 2021

Sounds fine. I can't push an updated package to nuget anyway. See #110

@Shane32
Copy link
Member

Shane32 commented Jul 20, 2021

Sounds fine. I can't push an updated package to nuget anyway. See #110

Fixed

@fiyazbinhasan
Copy link
Author

Finally! 🚀

@sungam3r sungam3r self-requested a review October 30, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants