Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace template1 with postgres:///template1 #227

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

hos
Copy link
Contributor

@hos hos commented Oct 15, 2024

Description

Performance impact

Security impact

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing this!

By the way, the protocol is postgres://user:pass@host:port/dbname; so postgres:///dbname essentially means "use defaults for user, pass, host and port" since that section (between second and third slash) is omitted entirely).

__tests__/settings.test.ts Outdated Show resolved Hide resolved
__tests__/settings.test.ts Outdated Show resolved Hide resolved
@benjie benjie merged commit 58d5662 into graphile:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants