Use the generic title "Front of identity document" instead of "Front …

…of identity card" See stripe#8511
googol7 · Sep 4, 2024 · 7abf37c · 7abf37c
1 parent 2cef912
commit 7abf37c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/identity/src/main/java/com/stripe/android/identity/ui/DocumentScanScreen.kt b/identity/src/main/java/com/stripe/android/identity/ui/DocumentScanScreen.kt
@@ -179,9 +179,9 @@ private fun DocumentCaptureScreen(
     }
 
     val title = if (targetScanType.isNullOrFront()) {
-        stringResource(id = R.string.stripe_front_of_id)
+        stringResource(id = R.string.stripe_front_of_id_document)
     } else {
-        stringResource(id = R.string.stripe_back_of_id)
+        stringResource(id = R.string.stripe_back_of_id_document)
     }
 
     Column(

diff --git a/identity/src/main/java/com/stripe/android/identity/ui/UploadScreen.kt b/identity/src/main/java/com/stripe/android/identity/ui/UploadScreen.kt
@@ -314,7 +314,7 @@ internal fun UploadImageDialog(
                         end = 24.dp
                     ),
                     text = stringResource(
-                        id = if (isFront) R.string.stripe_front_of_id else R.string.stripe_back_of_id
+                        id = if (isFront) R.string.stripe_front_of_id_document else R.string.stripe_back_of_id_document
                     ),
                     style = MaterialTheme.typography.subtitle1,
                     fontWeight = FontWeight.Bold
@@ -389,7 +389,7 @@ private fun SingleSideUploadRow(
         horizontalArrangement = Arrangement.SpaceBetween
     ) {
         Text(
-            text = stringResource(id = if (isFront) R.string.stripe_front_of_id else R.string.stripe_back_of_id),
+            text = stringResource(id = if (isFront) R.string.stripe_front_of_id_document else R.string.stripe_back_of_id_document),
             modifier = Modifier.align(CenterVertically)
         )
         when (uploadUiState) {
@@ -414,7 +414,7 @@ private fun SingleSideUploadRow(
                 Image(
                     painter = painterResource(id = R.drawable.stripe_check_mark),
                     contentDescription = stringResource(
-                        id = if (isFront) R.string.stripe_front_of_id_selected else R.string.stripe_back_of_id_selected
+                        id = if (isFront) R.string.stripe_front_of_id_document_selected else R.string.stripe_back_of_id_document_selected
                     ),
                     modifier = Modifier
                         .height(18.dp)

diff --git a/identity/src/test/java/com/stripe/android/identity/ui/DocumentScanScreenTest.kt b/identity/src/test/java/com/stripe/android/identity/ui/DocumentScanScreenTest.kt
@@ -96,7 +96,7 @@ class DocumentScanScreenTest {
         testDocumentScanScreen(
             scannerState = IdentityScanViewModel.State.Scanning(),
         ) {
-            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_front_of_id))
+            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_front_of_id_document))
             onNodeWithTag(SCAN_MESSAGE_TAG).assertTextEquals(context.getString(R.string.stripe_position_id_front))
             onNodeWithTag(CHECK_MARK_TAG).assertDoesNotExist()
             onNodeWithTag(CONTINUE_BUTTON_TAG).onChildAt(0).assertIsNotEnabled()
@@ -114,7 +114,7 @@ class DocumentScanScreenTest {
                 eq(IdentityScanState.ScanType.DOC_FRONT),
                 any()
             )
-            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_front_of_id))
+            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_front_of_id_document))
             onNodeWithTag(SCAN_MESSAGE_TAG).assertTextEquals(context.getString(R.string.stripe_hold_still))
             onNodeWithTag(CHECK_MARK_TAG).assertDoesNotExist()
             onNodeWithTag(CONTINUE_BUTTON_TAG).onChildAt(0).assertIsNotEnabled()
@@ -133,7 +133,7 @@ class DocumentScanScreenTest {
                 eq(IdentityScanState.ScanType.DOC_BACK),
                 any()
             )
-            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_back_of_id))
+            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_back_of_id_document))
             onNodeWithTag(SCAN_MESSAGE_TAG).assertTextEquals(context.getString(R.string.stripe_hold_still))
             onNodeWithTag(CHECK_MARK_TAG).assertDoesNotExist()
             onNodeWithTag(CONTINUE_BUTTON_TAG).onChildAt(0).assertIsNotEnabled()
@@ -148,7 +148,7 @@ class DocumentScanScreenTest {
             messageId = R.string.stripe_scanned
         ) {
             verify(mockDocumentScanViewModel).stopScan(any())
-            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_front_of_id))
+            onNodeWithTag(SCAN_TITLE_TAG).assertTextEquals(context.getString(R.string.stripe_front_of_id_document))
             onNodeWithTag(SCAN_MESSAGE_TAG).assertTextEquals(context.getString(R.string.stripe_scanned))
             onNodeWithTag(CHECK_MARK_TAG).assertExists()
             onNodeWithTag(CONTINUE_BUTTON_TAG).onChildAt(0).assertIsEnabled()