Skip to content

Commit

Permalink
Fix the experiment label
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 689077671
Change-Id: Iaaab910e5ec90a1e3ee0c7d850908eb654d10feb
  • Loading branch information
nilayvaish authored and copybara-github committed Oct 23, 2024
1 parent 9ccc64f commit 1d27c08
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tcmalloc/experiment_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ enum class Experiment : int {
// clang-format off
// go/keep-sorted start
TCMALLOC_BIG_SPAN, // TODO(b/304135905): Complete experiment.
TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS_ALLOCATED, // TODO(b/348043731): Complete experiment.
TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS, // TODO(b/348043731): Complete experiment.
TCMALLOC_REUSE_SIZE_CLASSES, // TODO(b/358126781): Complete experiment.
TEST_ONLY_L3_AWARE, // TODO(b/239977380): Complete experiment.
TEST_ONLY_TCMALLOC_BIG_SPAN, // TODO(b/304135905): Complete experiment.
Expand All @@ -47,7 +47,7 @@ struct ExperimentConfig {
inline constexpr ExperimentConfig experiments[] = {
// go/keep-sorted start
{Experiment::TCMALLOC_BIG_SPAN, "TCMALLOC_BIG_SPAN"},
{Experiment::TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS_ALLOCATED, "TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS_ALLOCATED"},
{Experiment::TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS, "TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS"},
{Experiment::TCMALLOC_REUSE_SIZE_CLASSES, "TCMALLOC_REUSE_SIZE_CLASSES"},
{Experiment::TEST_ONLY_L3_AWARE, "TEST_ONLY_L3_AWARE"},
{Experiment::TEST_ONLY_TCMALLOC_BIG_SPAN, "TEST_ONLY_TCMALLOC_BIG_SPAN"},
Expand Down
2 changes: 1 addition & 1 deletion tcmalloc/parameters.cc
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ bool Parameters::dense_trackers_sorted_on_spans_allocated() {
Experiment::
TEST_ONLY_TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS_ALLOCATED) ||
IsExperimentActive(
Experiment::TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS_ALLOCATED),
Experiment::TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS),
std::memory_order_relaxed);
});
return v;
Expand Down
2 changes: 1 addition & 1 deletion tcmalloc/variants.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ test_variants = [
"name": "dense_trackers_sorted_on_spans_allocated_exp",
"malloc": "//tcmalloc",
"deps": ["//tcmalloc:common_8k_pages"],
"env": {"BORG_EXPERIMENTS": "TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS_ALLOCATED"},
"env": {"BORG_EXPERIMENTS": "TCMALLOC_DENSE_TRACKERS_SORTED_ON_SPANS"},
},
{
"name": "huge_cache_release_30s",
Expand Down

0 comments on commit 1d27c08

Please sign in to comment.