dashboard/app: periodically remove coverage garbage from spanner #5550
+114
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
force-pushed
the
clean_up_db
branch
7 times, most recently
from
5fd8685
to
a18a545
Compare
a-nogikh
reviewed
Dec 2, 2024
dashboard/app/batch_coverage.go
Outdated
| // | ||
| // deleteGarbageSession returns the deleted rows count. | ||
| // (0, nil) means there is no data to delete. | ||
| func deleteGarbageSession(ctx context.Context) (int64, error) { |
There was a problem hiding this comment.
That might better belong to pkg/coveragedb.
tarasmadan
force-pushed
the
clean_up_db
branch
from
a18a545
to
fd3271d
Compare
tarasmadan
force-pushed
the
clean_up_db
branch
from
fd3271d
to
006c88c
Compare
|
https://cloud.google.com/spanner/docs/foreign-keys/overview#how-to-define-foreign-key-action may be a better way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.