Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Merge cmd/gen-test-vectors with integration/client_tests. #1178

Open
gdbelvin opened this issue Feb 1, 2019 · 1 comment
Open

Merge cmd/gen-test-vectors with integration/client_tests. #1178

gdbelvin opened this issue Feb 1, 2019 · 1 comment

Comments

@gdbelvin
Copy link
Contributor

gdbelvin commented Feb 1, 2019

cmd/gen-test-vectors and integration/client_tests.go are essentially duplicate code.

It would be ideal if go generate ./core/testdata ran a regular go test with an extra flag go test ./impl/integration --generate

Note, there is another asymmetry in that the tests that rely on core/testdata are in core/client. It's not clear if these should be moved.

@Zyqsempai
Copy link
Contributor

I'l take it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants