Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Build webpage for KT monitor #1174

Open
gdbelvin opened this issue Jan 28, 2019 · 8 comments
Open

Build webpage for KT monitor #1174

gdbelvin opened this issue Jan 28, 2019 · 8 comments
Labels

Comments

@gdbelvin
Copy link
Contributor

The KT monitor webpage in core/monitor is currently bare bones and could use an update to be more user friendly.

@Zyqsempai
Copy link
Contributor

Hm, i can't find it in core/monitor, or do i miss something?
BYTW, i will take this one for sure, just need some introduction and details.

@gdbelvin
Copy link
Contributor Author

Here's the URL of the main package:
https://github.com/google/keytransparency/blob/master/cmd/keytransparency-monitor/main.go

The objective is to show a list of Key Transparency revisions, and whether the monitor was able to fully verify them. I believe the current implementation runs the verification logic and stores the results.

@Zyqsempai
Copy link
Contributor

Any idea why i get ERROR: for log-server Cannot start service log-server: OCI runtime create failed: container_linux.go:344: starting container process caused "exec: \"/go/bin/trillian_log_server\": stat /go/bin/trillian_log_server: no such file or directory": unknown on docker-compose up -d ?

@Zyqsempai
Copy link
Contributor

So related to monitor webpage, as far as i can see from our http api, we provide only to endpoints for monitor:
/
/metrics
Metrics is just ling to the prometheus info, and / consist of two endpoints:
getState and getStateByRevision
As far as i get you want to prvide also a list of revisions?
Sorry, for dumb questions, not so familiar with that part of project, and that fact that I am not able to build and run it properly, not play's on my side ;)

@gdbelvin
Copy link
Contributor Author

gdbelvin commented Feb 1, 2019

Your first error is a bug that #1169 fixes.

at / we provide some json endpoints, yes, but I think we also want to have a home page that returns interesting stats in HTML table form:

  • Revision, Timestamp, Number of changes, and whether it was verified correctly.

Just discovered this issue is a duplicate of #803 and that #804 contains an (old) initial stab at it.

@Zyqsempai
Copy link
Contributor

So, what should we do? You want me to try to continue working on #804 ?
I am not the frontend specialist)) but it seems like almost finished)

@gdbelvin
Copy link
Contributor Author

gdbelvin commented Feb 4, 2019

Why don't I finish #804 since I have a bit more context on it.
Do you want to try #643 or any of the other HelpWanted issues?

@Zyqsempai
Copy link
Contributor

Sure, i'l take this one #1178

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants